Understanding and Implementing the DRY Principle in C#

Welcome to the very first lesson of the "Applying Clean Code Principles" course! In this lesson, we will focus on a fundamental concept in clean coding: the DRY ("Don't Repeat Yourself") principle. Understanding DRY is crucial for writing efficient, maintainable, and clean code. This principle is not just important for coding interviews but also in everyday software development. Today, we will dive deep into issues caused by repetitive code and explore strategies to combat redundancy. 🚀

Repetitive functionality in code can introduce several issues that affect the efficiency and maintainability of your software:

• Code Bloat: Repeating similar code across different parts of your application unnecessarily increases the size of the codebase. This repetition makes the code harder to navigate and increases the chances of introducing errors.

• Risk of Inconsistencies: When similar pieces of logic are scattered across different areas, it's easy for them to become out of sync during updates or bug fixes. This situation can result in logic discrepancies and potentially introduce new problems.

• Maintenance Challenges: Updating code often requires modifications in multiple places, leading to increased work and a higher likelihood of errors. Redundant code makes it difficult for developers to ensure all necessary changes have been made consistently.

To adhere to the DRY principle and avoid repeating yourself, several strategies can be employed:

• Extracting Method: Move repeated logic into a dedicated method that can be called wherever needed. This promotes reuse and simplifies updates.

• Extracting Variable: Consolidate repeated expressions or values into variables. This centralizes change, reducing the potential for errors.

• Replace Temp with Query: Use a method to compute values on demand rather than storing them in temporary variables, aiding readability and reducing redundancy.

Consider the following problematic code snippet where repetitive logic is used for calculating the total price based on different shipping methods:

public double CalculateClickAndCollectTotal(Order order)
{
    // Duplicate logic
    double itemsTotal = 0;
    foreach (Item item in order.Items)
    {
        itemsTotal += item.Price * item.Quantity;
    }
    double shippingCost = itemsTotal > 100 ? 0 : 5;
    return itemsTotal + shippingCost + order.Tax;
}

public double CalculatePostShipmentTotal(Order order, bool isExpress)
{
    // Duplicate logic
    double itemsTotal = 0;
    foreach (Item item in order.Items)
    {
        itemsTotal += item.Price * item.Quantity;
    }
    double shippingCost = isExpress ? itemsTotal * 0.1 : itemsTotal * 0.05;
    return itemsTotal + shippingCost + order.Tax;
}

Both methods contain duplicated logic for calculating the total price of items, making them error-prone and hard to maintain. Now, let's refactor this code.

By consolidating the shared logic into a separate method, we can eliminate redundancy and streamline updates:

public double CalculateClickAndCollectTotal(Order order)
{
    double itemsTotal = CalculateItemsTotal(order);
    double shippingCost = itemsTotal > 100 ? 0 : 5;
    return itemsTotal + shippingCost + order.Tax;
}

public double CalculatePostShipmentTotal(Order order, bool isExpress)
{
    double itemsTotal = CalculateItemsTotal(order);
    double shippingCost = isExpress ? itemsTotal * 0.1 : itemsTotal * 0.05;
    return itemsTotal + shippingCost + order.Tax;
}

private double CalculateItemsTotal(Order order)
{
    double itemsTotal = 0;
    foreach (Item item in order.Items)
    {
        itemsTotal += item.Price * item.Quantity;
    }
    return itemsTotal;
}

By extracting the CalculateItemsTotal method, we centralize the logic of item total calculation, leading to cleaner, more maintainable code.

Let's look at another example dealing with repeated calculations for discount rates:

public double ApplyDiscount(double price, Customer customer)
{
    double loyaltyDiscount = customer.LoyaltyLevel * 0.02;
    price *= (1 - loyaltyDiscount);
    // Additional discounts
    double seasonalDiscount = 0.10;
    price *= (1 - seasonalDiscount);
    return price;
}

Here, the discount rates are scattered throughout the code, which complicates management and updates.

We can simplify this by extracting the discount rates into variables:

public double ApplyDiscount(double price, Customer customer)
{
    double loyaltyDiscount = customer.LoyaltyLevel * 0.02;
    double seasonalDiscount = 0.10;
    
    double totalDiscount = 1 - loyaltyDiscount - seasonalDiscount;
    price *= totalDiscount;
    
    return price;
}

Now, with the totalDiscount variable, the logic is cleaner, more readable, and allows changes in just one place. 🎉

Our final example involves temporary variables that lead to repetition:

public bool IsEligibleForDiscount(Customer customer)
{
    bool newCustomer = customer.SignUpDate > DateTime.Now.AddMonths(-3);
    return newCustomer && customer.PurchaseHistory.Count > 5;
}

public bool IsEligibleForLoyaltyProgram(Customer customer)
{
    bool newCustomer = customer.SignUpDate > DateTime.Now.AddMonths(-3);
    return newCustomer || customer.LoyaltyLevel > 3;
}

The variable newCustomer is used in multiple places, causing duplicated logic.

Let's refactor by extracting the logic into a method, reducing duplication and enhancing modularity:

public bool IsEligibleForDiscount(Customer customer)
{
    return IsNewCustomer(customer) && customer.PurchaseHistory.Count > 5;
}

public bool IsEligibleForLoyaltyProgram(Customer customer)
{
    return IsNewCustomer(customer) || customer.LoyaltyLevel > 3;
}

private bool IsNewCustomer(Customer customer)
{
    return customer.SignUpDate > DateTime.Now.AddMonths(-3);
}

By creating the IsNewCustomer method, we've simplified the code and made it more maintainable. 🚀

In this lesson, you learned about the DRY principle and strategies like Extracting Method, Extracting Variable, and Replace Temp with Query to eliminate code redundancy. These strategies help to create code that is easier to maintain, enhance, and understand. Next, you'll have the opportunity to apply these concepts in practical exercises, strengthening your ability to refactor code and uphold clean coding standards. Happy coding! 😊