Withdrawing Unsupported Blockers
Introduction
Welcome back to Comments That Get Merged. We’re at lesson 4, where we’ll practice what to do when an author challenges a blocking review comment. A disagreement does not need to become a stalemate: we can return to the shared requirement, check the evidence, and revise our feedback when it is not supported. We’ll follow a ticket lookup example, decide what to withdraw, preserve a useful request for documentation and tests, and close the review without escalation.
Tracing the Ticket Lookup in tickets.py and main.py
The example looks up an in-memory ticket by ID. In the original proposal, app/tickets.py defines create_ticket(), which stores a ticket and returns that same object, and find_ticket(), which uses the dictionary’s get() method. get() returns None when the ID is absent rather than raising an exception.
In main.py, the program creates ticket 1, looks it up, and prints its ID and title. The supporting requirements.txt and .flake8 files configure the test and lint tools; they do not change the lookup behavior.
Reading the Review Exchange: A Blocking Comment Meets Pushback
As in earlier lessons, we’ll read this review as a timeline: Original proposal → Reviewer request → Author pushback → Reviewer follow-up → Author revision. Everything up to the follow-up is judged against the original proposal shown above.
The review in REVIEW.md starts with a blocking request: raise an exception when an ID is missing. The reviewer gives a reason — that callers might overlook None — but the reason alone does not establish that the proposed behavior violates the requirement. The author responds by pointing to the agreed contract. Notice the difference between dismissing a concern and answering it with relevant evidence.
The author does not claim that exceptions are always wrong. Instead, the response narrows the discussion to this change: the shared requirement says a missing lookup has a no-result outcome. That gives us a concrete basis for checking whether the blocking comment is justified.
