Labeling Review Feedback Clearly
Introduction
Welcome back to Comments That Get Merged. We’re now in lesson 2, building on the specific, respectful feedback you practiced in the previous lesson. This time, we’ll look at how labels help readers distinguish a required correctness fix from an optional suggestion. We’ll follow a ticket’s priority from creation to validation, then connect that behavior to the review comments and their resolution. By the end, we’ll be able to label feedback clearly, explain the reason for each label, and avoid turning a preference into a requirement.
The Conventional Comments Vocabulary: Blocking vs Non-Blocking Labels
A label gives a review comment a quick signal about its purpose and urgency. In the style used here, issue (blocking) marks a problem that must be resolved before approval. nit (non-blocking) marks a small, optional improvement that should not hold up the change.
The label does not replace the explanation. We still need to say what the code does, why it matters, and what action would help. As in the previous lesson, feedback works best when it points to observable behavior and a practical impact. The label adds one more piece of context: whether the author is expected to act now or may consider the suggestion later.
Tracing the Priority Workflow in main.py and set_priority()
To understand the review, let’s trace what happens when the example runs. In main.py, create_ticket() creates a ticket and stores it in a dictionary. The new ticket begins with "normal" priority; then main() changes it to "high" and prints its ID and priority.
The validation happens in app/tickets.py. set_priority() accepts three values and raises ValueError for anything else. That guard matters because downstream priority handling should receive values it understands.
The first snippet sets the default and enforces the allowed values. The second creates a ticket, assigns a supported value, and displays the result:
